Speed up a test which keeps timing out #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maresb
force-pushed
the
fix-flaky-test
branch
from
8872f87
to
0d08a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several of the recent runs on Windows have been timing out due to the test
test_run_lock_with_update_filter_platform, which has a timeout of 120 seconds. This test makes two calls toconda-lock lock. In this PR I precompute the lockfile for the first call.There are similar tests which may benefit from the same precomputation such as
test_remove_dependency,test_move_dependency_from_pip_section,test_run_lock_with_locked_environment_files, but I'll do those later if needed.CC: @mfisher87